Currently, the DualSense is my babe. I really like how it feels in my hands and I like the haptic feedback when it's used. The adaptive triggers are both a blessing and a curse and the D-pad feels a little squishy sometimes. Unsurprisingly, they are not the most well built either. I'm not hard on my controllers but I've had one DualSense die, one replacement arrived DoA and the DualSense that came with my PS5 still works fine but the face buttons are a little mushy. I use it for most my PC games and a lot of emulation. However...
The Xbox One controller is really nice too. Sadly it doesn't have the compatibility of the 360 controller, but I think it's Microsoft's best feeling controller. It was my favorite until the DualSense came along. I still use it occasionally, but really only for racing games. The triggers feel good for accelerating and braking and I like the position of the left stick better for racing as well. Their build quality is kinda shit though. I've gone through a handful of them and I'm legit shocked the two we currently have are still working past the replacement warranty.
The 8BitDo Pro 2 sees a lot of use as well. It's THE controller for my Switch and I use it for emulating Nintendo games or PC games that my PS5 controller doesn't want to play nice with. I'm a bit sad I don't have the newer model with the Hall effect joysticks, but it's lasted years with no issues at all so I'll cross the replacement bridge when/if it comes. It's also cheaper than all the first party controllers by a good chunk and like half the price of modern controllers if you opt for the wired version.
Finally, the GameCube controller. It's always felt super nice to hold, the clicking of the L and R triggers is one of the best feelings ever and you can even connect it to your Switch and/or PC with the 8BitDo Gbros adapter! I've also never had one of them truly die on me, which is not the case for literally any other console. I have 4 (3 wired, one WaveBird) and while two of the wired ones have ever so slightly loose sticks, the other two are in perfect condition. And even the loose ones are perfectly useable! It's not a total nightmare like the N64 stick.
And, well, this isn't a controller, but the 8BitDo Wireless USB Adapter 2 is excellent. It works with PCs as well as the Switch. So you can play the Switch with a PS3 controller! Yippie, I guess? I use it for both the PC and Switch. When connected to a PC it basically just makes your computer think the paired controller is a 360 controller, so it's compatibility is nice. It works with every wireless controller I own, though I'm sure there's some third party or such controllers that it won't play nice with. x) The only real downside is only one controller can be paired at a time. I swear I'm not being paid by 8BitDo to advertise their shit either. :V I've just been super happy with all their stuff so far.